Wait for odometry message before setting manual datum so that the base and world frame names can be set. #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As with the other PR, if you could fix the uncrustify errors, that would be great (they may not be from this PR, not sure). |
|
@ayrton04 Hi! That is a large list of lint/uncrustify errors, none of which resulted from my changes. I have only changed 2 files, but the lint errors are across almost all files. I would be reluctant to make all of those changes on these PRs since these PRs are very small in scope. What do you recommend? |
|
Yeah, let's ignore it. Maybe before this package gets officially sunsetted, we'll do a separate PR to clean that all up. |
ayrton04
approved these changes
Oct 26, 2023
|
Hi @ayrton04. When will these two pull requests be merged? Thanks! |
HaoguangYang
added a commit
to HaoguangYang/robot_localization
that referenced
this pull request
Mar 26, 2024
* Changelogs * 3.4.0 * Adding issue templates * Update issue templates * install headers (cra-ros-pkg#786) * bump Humble to 3.4.1 for release (cra-ros-pkg#789) * bumping to 3.4.2 for humble release (cra-ros-pkg#806) * bumping humble to 3.5.1 to override incorrect binaries (cra-ros-pkg#816) * Utm using geographiclib humble branch (cra-ros-pkg#834) * Add single test for navsat_conversions * Add a southern point to the navsat_transform test * LLtoUTM using GeographicLib * Use GeographicLib for UTMtoLL conversions * Linting * Forgot include * Fix compilation * Calculate gamma because it's a function output and was supplied before * Also test for gamma conversion * Align naming and install * Utm using geographiclib ros2 branch (cra-ros-pkg#833) * Add single test for navsat_conversions * Add a southern point to the navsat_transform test * LLtoUTM using GeographicLib * Use GeographicLib for UTMtoLL conversions * Linting * Forgot include * Fix compilation * Calculate gamma because it's a function output and was supplied before * Also test for gamma conversion * Align naming and install * Test navsat transform functionality (cra-ros-pkg#838) * Wait for odometry message before setting manual datum so that the base and world frame names can be set. (cra-ros-pkg#835) * wait for odom msg before setting manual datum * Wait for odometry message before setting manual datum so that the base and world frame names can be set. (cra-ros-pkg#836) * wait for odom msg before setting manual datum * fix header timestamp (cra-ros-pkg#852) Co-authored-by: Luke Chang <[email protected]> * fix header timestamp (cra-ros-pkg#852) Co-authored-by: Luke Chang <[email protected]> * Changelogs * 3.5.2 * Fixing angle clamping for humble (cra-ros-pkg#854) * fix: modify dual_ekf_navsat_example.launch file to remap the correct imu topic (cra-ros-pkg#857) * Feature/set utm service (cra-ros-pkg#856) * Forward port Fix/set utm map frame change --------- Signed-off-by: Tim Clephas <[email protected]> * simplified calculation * simplified calculation * Update issue templates * Migrate static tfs to ros2 format. (cra-ros-pkg#864) * Fix throttle duration (cra-ros-pkg#866) * Fix throttle duration * Update ukf.yaml to match ekf.yaml (cra-ros-pkg#867) Add missing *_pose_use_child_frame parameter. * updated file formatting --------- Signed-off-by: Tim Clephas <[email protected]> Co-authored-by: Tom Moore <[email protected]> Co-authored-by: Olivier Kermorgant <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Tim Clephas <[email protected]> Co-authored-by: Tom Greier <[email protected]> Co-authored-by: Luke Chang <[email protected]> Co-authored-by: Luke Chang <[email protected]> Co-authored-by: joeldushouyu <[email protected]> Co-authored-by: Mukunda Bharatheesha <[email protected]> Co-authored-by: thandal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #820
Wait for odom callback before setting manual datum so that the reference frame names are properly set.
Otherwise, there is a race condition where if the transform callback runs before the odom callback, then the reference frame names are not set, and the navsat_transform will publish incorrect transforms for cartesian<->world frames.